Refactor job scraping logic to improve accuracy and remove unused city handling#655
Merged
lalalaurentiu merged 2 commits intopeviitor-ro:mainfrom Oct 28, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the job scraping logic in
sites/veoneer.pyto improve accuracy and maintainability. The main changes involve updating the HTML selectors to match the current site structure and removing unused or redundant code related to city and county mapping.Scraping logic improvements:
divelements with specific classes to searching for aulelement with the IDjobs_list_container, and updated the job item selector to target alllielements. This ensures the scraper matches the current structure of the target website.aelement instead of aspanwith a specific class, reflecting changes in the site's markup._counties.get_county(city), removing the previous use of theacurate_city_and_countymapping and related dictionary. This simplifies and clarifies how counties are determined for each city.Code cleanup:
acurate_city_and_countyfromutils, as it is no longer used in the code.acurate_citydictionary, which previously mapped Iasi city and county, to streamline city and county handling